[
https://issues.apache.org/jira/browse/HADOOP-18145?focusedWorklogId=746995&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-746995
]
ASF GitHub Bot logged work on HADOOP-18145:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/22 07:59
Start Date: 24/Mar/22 07:59
Worklog Time Spent: 10m
Work Description: zhongjingxiong commented on a change in pull request
#4036:
URL: https://github.com/apache/hadoop/pull/4036#discussion_r834015838
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java
##########
@@ -706,35 +706,40 @@ public void testCreateLocalTempFile() throws IOException {
public void testUnZip() throws IOException {
// make sa simple zip
final File simpleZip = new File(del, FILE);
- OutputStream os = new FileOutputStream(simpleZip);
- ZipOutputStream tos = new ZipOutputStream(os);
- try {
- ZipEntry ze = new ZipEntry("foo");
- byte[] data = "some-content".getBytes("UTF-8");
- ze.setSize(data.length);
- tos.putNextEntry(ze);
- tos.write(data);
- tos.closeEntry();
- tos.flush();
- tos.finish();
- } finally {
- tos.close();
- }
-
- // successfully unzip it into an existing dir:
- FileUtil.unZip(simpleZip, tmp);
- // check result:
- assertTrue(new File(tmp, "foo").exists());
- assertEquals(12, new File(tmp, "foo").length());
-
- final File regularFile = new File(tmp, "QuickBrownFoxJumpsOverTheLazyDog");
- regularFile.createNewFile();
- assertTrue(regularFile.exists());
- try {
- FileUtil.unZip(simpleZip, regularFile);
- assertTrue("An IOException expected.", false);
- } catch (IOException ioe) {
- // okay
+ try (OutputStream os = new FileOutputStream(simpleZip);
+ ZipArchiveOutputStream tos = new ZipArchiveOutputStream(os)) {
+ try {
+ ZipArchiveEntry ze = new ZipArchiveEntry("foo");
+ ze.setUnixMode(0555);
+ byte[] data = "some-content".getBytes("UTF-8");
+ ze.setSize(data.length);
+ tos.putArchiveEntry(ze);
+ tos.write(data);
+ tos.closeArchiveEntry();
+ tos.flush();
+ tos.finish();
+ } finally {
+ tos.close();
Review comment:
Let me modify that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 746995)
Time Spent: 6h 40m (was: 6.5h)
> Fileutil's unzip method causes unzipped files to lose their original
> permissions
> --------------------------------------------------------------------------------
>
> Key: HADOOP-18145
> URL: https://issues.apache.org/jira/browse/HADOOP-18145
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 2.7.2
> Reporter: jingxiong zhong
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> When Spark decompresses the zip file, if the original file has the executable
> permission, but the unzip method of FileUtil is invoked, the decompressed
> file loses the executable permission, we should save the original permission
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
