zhongjingxiong commented on pull request #4036: URL: https://github.com/apache/hadoop/pull/4036#issuecomment-1080420412
Thank you for your review. @steveloughran 1.the design of this method is more redundant, but more clear, and I will improve it. 2.the test case, I try to use UserPrincipalLookupService class to update the current user groups and others, to verify the current file permissions for user groups and others as a result, but for ordinary users, is impossible to setOwner operation, this leads to the current user can't change, to this, Do you have any good suggestions? > then the permissionsFromMode() method can be tested passing in permissions for users group and other only, e.g. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
