hchaverri commented on code in PR #4092: URL: https://github.com/apache/hadoop/pull/4092#discussion_r852348271
########## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java: ########## @@ -579,4 +616,55 @@ public void testEmptyToken() throws IOException { assertEquals(token1, token2); assertEquals(token1.encodeToUrlString(), token2.encodeToUrlString()); } + + @Test + public void testDelegationTokenSecretManagerMetrics() throws Exception { + TestDelegationTokenSecretManager dtSecretManager = + new TestDelegationTokenSecretManager(24*60*60*1000, + 10*1000, 1*1000, 60*60*1000); + try { + dtSecretManager.startThreads(); + + Assert.assertEquals(0, dtSecretManager.metrics.storeToken.lastStat().numSamples()); + final Token<TestDelegationTokenIdentifier> token = + generateDelegationToken(dtSecretManager, "SomeUser", "JobTracker"); + Assert.assertEquals(1, dtSecretManager.metrics.storeToken.lastStat().numSamples()); + + Assert.assertEquals(0, dtSecretManager.metrics.updateToken.lastStat().numSamples()); + dtSecretManager.renewToken(token, "JobTracker"); + Assert.assertEquals(1, dtSecretManager.metrics.updateToken.lastStat().numSamples()); + + Assert.assertEquals(0, dtSecretManager.metrics.removeToken.lastStat().numSamples()); + dtSecretManager.cancelToken(token, "JobTracker"); + Assert.assertEquals(1, dtSecretManager.metrics.removeToken.lastStat().numSamples()); + } finally { + dtSecretManager.stopThreads(); + } + } + + @Test + public void testDelegationTokenSecretManagerMetricsFailures() throws Exception { + TestFailureDelegationTokenSecretManager dtSecretManager = new TestFailureDelegationTokenSecretManager(); + + try { + dtSecretManager.startThreads(); + + final Token<TestDelegationTokenIdentifier> token = + generateDelegationToken(dtSecretManager, "SomeUser", "JobTracker"); + + dtSecretManager.setThrowError(true); + + Assert.assertEquals(0, dtSecretManager.metrics.tokenFailure.value()); + generateDelegationToken(dtSecretManager, "SomeUser", "JobTracker"); + Assert.assertEquals(1, dtSecretManager.metrics.tokenFailure.value()); + + LambdaTestUtils.intercept(Exception.class, () -> dtSecretManager.renewToken(token, "JobTracker")); Review Comment: I've updated this to expect IOException, since that's the exception we throw in TestFailureDelegationTokenSecretManager. We're currently not tracking duration of failures per a previous comment by @omalley ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java: ########## @@ -96,6 +108,10 @@ private String formatTokenId(TokenIdent id) { * Access to currentKey is protected by this object lock */ private DelegationKey currentKey; + /** + * Metrics to track token management operations Review Comment: Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org