[ https://issues.apache.org/jira/browse/HADOOP-18172?focusedWorklogId=758147&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-758147 ]
ASF GitHub Bot logged work on HADOOP-18172: ------------------------------------------- Author: ASF GitHub Bot Created on: 18/Apr/22 22:29 Start Date: 18/Apr/22 22:29 Worklog Time Spent: 10m Work Description: virajith commented on code in PR #4106: URL: https://github.com/apache/hadoop/pull/4106#discussion_r852455310 ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java: ########## @@ -61,7 +61,7 @@ @InterfaceAudience.Private Review Comment: Public? ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java: ########## @@ -458,11 +458,11 @@ private boolean hasFallbackLink() { * there will be root to root mapping. So, root does not represent as * internalDir. */ - protected boolean isRootInternalDir() { + public boolean isRootInternalDir() { Review Comment: Why limit to only these methods? Should the other package-private methods also be made public? why/why not? Issue Time Tracking ------------------- Worklog Id: (was: 758147) Time Spent: 2h 20m (was: 2h 10m) > Change scope of getRootFallbackLink for InodeTree to make them accessible > from outside package > ---------------------------------------------------------------------------------------------- > > Key: HADOOP-18172 > URL: https://issues.apache.org/jira/browse/HADOOP-18172 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Xing Lin > Assignee: Xing Lin > Priority: Minor > Labels: pull-request-available > Time Spent: 2h 20m > Remaining Estimate: 0h > > Sometimes, we need to access rootFallBackLink in InodeTree from another > package. One such case is we extend from ViewFileSystem but want to put the > new filesystem in org.apache.hadoop.fs package, instead of > org.apache.hadoop.fs.viewfs package. As a result, we need make them public, > similar as what we did for getMountPoints() in HADOOP-18100. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org