iwasakims commented on code in PR #4174:
URL: https://github.com/apache/hadoop/pull/4174#discussion_r853768370
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestShell.java:
##########
@@ -528,4 +528,9 @@ public Boolean get() {
shexc1.getProcess().waitFor();
shexc2.getProcess().waitFor();
}
+
+ @Test
+ public void testIsJavaVersionAtLeast() {
+ assertTrue(Shell.isJavaVersionAtLeast(8));
+ }
Review Comment:
This test succeeds on Java 7 since the `Shell.isJavaVersionAtLeast(8)`
returns true even on Java 7. We should have a comment for justification at
least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
