GauthamBanasandra commented on code in PR #4228:
URL: https://github.com/apache/hadoop/pull/4228#discussion_r858176463
##########
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/jni_helper.c:
##########
@@ -487,10 +488,10 @@ static ssize_t wildcard_expandPath(const char* path,
char* expanded)
* allocated after using this function with expandedClasspath=NULL to get the
* right size.
*/
-static ssize_t getClassPath_helper(const char *classpath, char*
expandedClasspath)
+static x_platform_ssize_t getClassPath_helper(const char *classpath, char*
expandedClasspath)
{
- ssize_t length;
- ssize_t retval;
+ x_platform_ssize_t length;
Review Comment:
I've defined `ssize_t ` type under the `XPlatform::` namespace in C++ files.
Since C lacks namespaces, I had to resort to adding `x_platform_` prefix.
But no worries, even I had some reservations with this approach. I'll just
rewrite this PR to use a common `ssize_t` typedef in a header file. We'll worry
about the future possible conflicts with `ssize_t` if/whenever it happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
