[
https://issues.apache.org/jira/browse/HADOOP-16965?focusedWorklogId=762091&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-762091
]
ASF GitHub Bot logged work on HADOOP-16965:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/22 02:39
Start Date: 26/Apr/22 02:39
Worklog Time Spent: 10m
Work Description: virajith commented on code in PR #4171:
URL: https://github.com/apache/hadoop/pull/4171#discussion_r858185434
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:
##########
@@ -362,9 +364,15 @@ public OutputStream createFile(final Path path, final
boolean overwrite, final F
client,
AbfsHttpConstants.FORWARD_SLASH + getRelativePath(path),
0,
- abfsConfiguration.getWriteBufferSize(),
- abfsConfiguration.isFlushEnabled(),
- abfsConfiguration.isOutputStreamFlushDisabled());
+ populateAbfsOutputStreamContext());
Review Comment:
I still don't see the additional space removed here. Can you check?
Issue Time Tracking
-------------------
Worklog Id: (was: 762091)
Time Spent: 2h 40m (was: 2.5h)
> Introduce StreamContext for Abfs Input and Output streams.
> ----------------------------------------------------------
>
> Key: HADOOP-16965
> URL: https://issues.apache.org/jira/browse/HADOOP-16965
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/azure
> Reporter: Mukund Thakur
> Assignee: Mukund Thakur
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> The number of configuration keeps growing in AbfsOutputStream and
> AbfsInputStream as we keep on adding new features. It is time to refactor the
> configurations in a separate class like StreamContext and pass them around.
> This is will improve the readability of code and reduce cherry-pick-backport
> pain.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
