ashutoshcipher commented on code in PR #4229:
URL: https://github.com/apache/hadoop/pull/4229#discussion_r864781195
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/ConfRefreshTokenBasedAccessTokenProvider.java:
##########
@@ -102,32 +102,29 @@ public synchronized String getAccessToken() throws
IOException {
}
void refresh() throws IOException {
- try {
- OkHttpClient client = new OkHttpClient();
- client.setConnectTimeout(URLConnectionFactory.DEFAULT_SOCKET_TIMEOUT,
- TimeUnit.MILLISECONDS);
- client.setReadTimeout(URLConnectionFactory.DEFAULT_SOCKET_TIMEOUT,
- TimeUnit.MILLISECONDS);
+ OkHttpClient client =
+ new
OkHttpClient.Builder().connectTimeout(URLConnectionFactory.DEFAULT_SOCKET_TIMEOUT,
+ TimeUnit.MILLISECONDS)
+ .readTimeout(URLConnectionFactory.DEFAULT_SOCKET_TIMEOUT,
TimeUnit.MILLISECONDS)
+ .build();
- String bodyString = Utils.postBody(GRANT_TYPE, REFRESH_TOKEN,
- REFRESH_TOKEN, refreshToken,
- CLIENT_ID, clientId);
+ String bodyString =
+ Utils.postBody(GRANT_TYPE, REFRESH_TOKEN, REFRESH_TOKEN, refreshToken,
CLIENT_ID, clientId);
- RequestBody body = RequestBody.create(URLENCODED, bodyString);
-
- Request request = new Request.Builder()
- .url(refreshURL)
- .post(body)
- .build();
- Response responseBody = client.newCall(request).execute();
+ RequestBody body = RequestBody.create(bodyString, URLENCODED);
+ Request request = new Request.Builder().url(refreshURL).post(body).build();
+ try (Response responseBody = client.newCall(request).execute()) {
+ if (!responseBody.isSuccessful()) {
+ throw new IOException("Unexpected code " + responseBody);
+ }
if (responseBody.code() != HttpStatus.SC_OK) {
- throw new IllegalArgumentException("Received invalid http response: "
- + responseBody.code() + ", text = " + responseBody.toString());
+ throw new IllegalArgumentException(
+ "Received invalid http response: " + responseBody.code() + ", text
= "
+ + responseBody.toString());
}
- Map<?, ?> response = JsonSerialization.mapReader().readValue(
- responseBody.body().string());
+ Map<?, ?> response =
JsonSerialization.mapReader().readValue(responseBody.body().string());
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
