[ https://issues.apache.org/jira/browse/HADOOP-18224?focusedWorklogId=767342&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-767342 ]
ASF GitHub Bot logged work on HADOOP-18224: ------------------------------------------- Author: ASF GitHub Bot Created on: 06/May/22 17:53 Start Date: 06/May/22 17:53 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on PR #4267: URL: https://github.com/apache/hadoop/pull/4267#issuecomment-1119854191 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 1m 1s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | |||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 16m 25s | | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 25m 52s | | trunk passed | | +1 :green_heart: | compile | 26m 20s | | trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | compile | 23m 5s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | mvnsite | 20m 55s | | trunk passed | | -1 :x: | javadoc | 1m 44s | [/branch-javadoc-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4267/4/artifact/out/branch-javadoc-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt) | root in trunk failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1. | | +1 :green_heart: | javadoc | 9m 6s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | shadedclient | 143m 5s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 52s | | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 27m 47s | | the patch passed | | +1 :green_heart: | compile | 25m 4s | | the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | -1 :x: | javac | 25m 4s | [/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4267/4/artifact/out/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt) | root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 1091 new + 1817 unchanged - 0 fixed = 2908 total (was 1817) | | +1 :green_heart: | compile | 23m 3s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | -1 :x: | javac | 23m 3s | [/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4267/4/artifact/out/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt) | root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1013 new + 1692 unchanged - 0 fixed = 2705 total (was 1692) | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | mvnsite | 19m 57s | | the patch passed | | +1 :green_heart: | xml | 0m 4s | | The patch has no ill-formed XML file. | | -1 :x: | javadoc | 1m 36s | [/patch-javadoc-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4267/4/artifact/out/patch-javadoc-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt) | root in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1. | | +1 :green_heart: | javadoc | 9m 3s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | shadedclient | 32m 6s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | -1 :x: | unit | 844m 11s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4267/4/artifact/out/patch-unit-root.txt) | root in the patch passed. | | +1 :green_heart: | asflicense | 2m 46s | | The patch does not generate ASF License warnings. | | | | 1122m 35s | | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.yarn.sls.TestSLSDagAMSimulator | | | hadoop.yarn.sls.TestSLSStreamAMSynth | | | hadoop.yarn.sls.TestSLSRunner | | | hadoop.yarn.sls.TestReservationSystemInvariants | | | hadoop.yarn.sls.TestSLSGenericSynth | | | hadoop.yarn.sls.nodemanager.TestNMSimulator | | | hadoop.yarn.sls.appmaster.TestAMSimulator | | | hadoop.yarn.client.TestResourceManagerAdministrationProtocolPBClientImpl | | | hadoop.yarn.client.TestGetGroups | | | hadoop.yarn.webapp.TestRMWithXFSFilter | | | hadoop.yarn.server.resourcemanager.webapp.TestRMWebappAuthentication | | | hadoop.yarn.server.resourcemanager.TestClientRMService | | | hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokenAuthentication | | | hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher | | | hadoop.yarn.server.resourcemanager.TestRMHA | | | hadoop.yarn.server.resourcemanager.metrics.TestCombinedSystemMetricsPublisher | | | hadoop.yarn.server.timeline.security.TestTimelineAuthenticationFilterForV1 | | | hadoop.yarn.server.applicationhistoryservice.TestApplicationHistoryServer | | | hadoop.yarn.server.timeline.webapp.TestTimelineWebServicesWithSSL | | | hadoop.yarn.server.router.webapp.TestRouterWebServicesREST | | | hadoop.cli.TestHDFSCLI | | | hadoop.hdfs.server.federation.security.TestRouterSecurityManager | | | hadoop.mapred.TestLocalDistributedCacheManager | | | hadoop.crypto.key.kms.server.TestKMSWithZK | | | hadoop.crypto.key.kms.server.TestKMS | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4267/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4267 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml | | uname | Linux 77289af39227 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / f13f50d1d352cefb0aae603f4970fbe002546c74 | | Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4267/4/testReport/ | | Max. process+thread count | 3015 (vs. ulimit of 5500) | | modules | C: hadoop-project hadoop-client-modules/hadoop-client-minicluster . U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4267/4/console | | versions | git=2.25.1 maven=3.6.3 | | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. Issue Time Tracking ------------------- Worklog Id: (was: 767342) Time Spent: 0.5h (was: 20m) > Upgrade maven compiler plugin to 3.10.1 > --------------------------------------- > > Key: HADOOP-18224 > URL: https://issues.apache.org/jira/browse/HADOOP-18224 > Project: Hadoop Common > Issue Type: Task > Reporter: Viraj Jasani > Assignee: Viraj Jasani > Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently we are using maven-compiler-plugin 3.1 version, which is quite old > (2013) and it's also pulling in vulnerable log4j dependency: > {code:java} > [INFO] > org.apache.maven.plugins:maven-compiler-plugin:maven-plugin:3.1:runtime > [INFO] org.apache.maven.plugins:maven-compiler-plugin:jar:3.1 > [INFO] org.apache.maven:maven-plugin-api:jar:2.0.9 > [INFO] org.apache.maven:maven-artifact:jar:2.0.9 > [INFO] org.codehaus.plexus:plexus-utils:jar:1.5.1 > [INFO] org.apache.maven:maven-core:jar:2.0.9 > [INFO] org.apache.maven:maven-settings:jar:2.0.9 > [INFO] org.apache.maven:maven-plugin-parameter-documenter:jar:2.0.9 > ... > ... > ... > [INFO] log4j:log4j:jar:1.2.12 > [INFO] commons-logging:commons-logging-api:jar:1.1 > [INFO] com.google.collections:google-collections:jar:1.0 > [INFO] junit:junit:jar:3.8.2 > {code} > > We should upgrade to 3.10.1 (latest Mar, 2022) version of > maven-compiler-plugin. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org