ayushtkn commented on code in PR #4052: URL: https://github.com/apache/hadoop/pull/4052#discussion_r867388481
########## hadoop-project/pom.xml: ########## @@ -1626,13 +1688,45 @@ <groupId>org.apache.hbase</groupId> <artifactId>hbase-server</artifactId> <version>${hbase.version}</version> + <exclusions> + <exclusion> + <groupId>log4j</groupId> + <artifactId>log4j</artifactId> + </exclusion> + </exclusions> + </dependency> + <dependency> + <groupId>org.apache.hbase</groupId> + <artifactId>hbase-server</artifactId> + <version>${hbase.version}</version> + <scope>test</scope> Review Comment: @iwasakims hbase-server was already there, with compile scope, why was it added here again with test scope? It seems to give warnings while building 3.3.3 to me ``` [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.hadoop:hadoop-project:pom:3.3.3 [WARNING] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.apache.hbase:hbase-server:jar -> duplicate declaration of version ${hbase.version} @ line 1691, column 19 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org