omalley commented on code in PR #4181:
URL: https://github.com/apache/hadoop/pull/4181#discussion_r870545469
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java:
##########
@@ -133,6 +138,11 @@ public INode(String pathToNode, UserGroupInformation aUgi)
{
// and is read only.
abstract boolean isInternalDir();
+ /**
+ * INode representing a INodeDir which also contains a INodeLink(nested
mount point)
+ */
+ abstract boolean isDirAndLink();
+
// INode linking to another filesystem. Represented
// via mount table link config entries.
boolean isLink() {
Review Comment:
You already have whether it is an internal node. Change the traversal code
to use that rather than isLink. I understand that the new method lets you
functionally accomplish your goal, but the abstraction is wrong. You could get
there by renaming the methods, but that isn't as satisfying as correcting this
patch to define isLink correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
