snvijaya commented on code in PR #3335:
URL: https://github.com/apache/hadoop/pull/3335#discussion_r870775641
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java:
##########
@@ -159,12 +163,114 @@ public long getBytesReceived() {
return bytesReceived;
}
- public ListResultSchema getListResultSchema() {
- return listResultSchema;
+
+ protected void setStatusCode(final int statusCode) {
Review Comment:
Yes, even when on Fastpath, driver will receive HttpStatus code and other
relevant details for the corresponding request, this enables existing logic for
retry/throttling handling to continue to work. Has to be on base class.
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java:
##########
@@ -159,12 +163,114 @@ public long getBytesReceived() {
return bytesReceived;
}
- public ListResultSchema getListResultSchema() {
- return listResultSchema;
+
+ protected void setStatusCode(final int statusCode) {
+ this.statusCode = statusCode;
+ }
+
+ protected void setStatusDescription(final String statusDescription) {
+ this.statusDescription = statusDescription;
+ }
+
+ protected void setStorageErrorCode(final String storageErrorCode) {
+ this.storageErrorCode = storageErrorCode;
+ }
+
+ protected void setStorageErrorMessage(final String storageErrorMessage) {
+ this.storageErrorMessage = storageErrorMessage;
+ }
+
+ protected void setRequestId(final String requestId) {
+ this.requestId = requestId;
+ }
+
+ protected void setBytesSent(final int bytesSent) {
+ this.bytesSent = bytesSent;
+ }
+
+ protected void setBytesReceived(final long bytesReceived) {
+ this.bytesReceived = bytesReceived;
+ }
+
+ protected void setRecvResponseTimeMs(final long recvResponseTimeMs) {
+ this.recvResponseTimeMs = recvResponseTimeMs;
+ }
+
+ protected long getRecvResponseTimeMs() {
+ return this.recvResponseTimeMs;
+ }
+
+ protected void setAuthType(final
org.apache.hadoop.fs.azurebfs.services.AuthType authType) {
+ this.authType = authType;
+ }
+
+ protected void setAuthToken(final String authToken) {
+ this.authToken = authToken;
+ }
+
+ protected void setResponseContentBuffer(final byte[] responseContentBuffer) {
+ this.responseContentBuffer = responseContentBuffer;
+ }
+
+ protected void setAbfsHttpHeaders(final List<AbfsHttpHeader>
abfsHttpHeaders) {
+ this.abfsHttpHeaders = abfsHttpHeaders;
+ }
+
+ protected List<AbfsHttpHeader> getAbfsHttpHeaders() {
+ return abfsHttpHeaders;
+ }
+
+ protected AbfsRestOperationType getOpType() {
+ return opType;
+ }
+
+ protected URL getUrl() {
+ return url;
+ }
+
+ protected boolean isTraceEnabled() {
+ return isTraceEnabled;
}
- public String getResponseHeader(String httpHeader) {
- return connection.getHeaderField(httpHeader);
+ protected void setConnectionTimeMs(final long connectionTimeMs) {
+ this.connectionTimeMs = connectionTimeMs;
+ }
+
+ protected void setSendRequestTimeMs(final long sendRequestTimeMs) {
+ this.sendRequestTimeMs = sendRequestTimeMs;
+ }
+
+ protected void setExpectedAppendPos(final String expectedAppendPos) {
Review Comment:
Yes, expect this to be a field to be updated when on Fastpath later on.
Hence retained on the abstract class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
