[ https://issues.apache.org/jira/browse/HADOOP-17864?focusedWorklogId=769318&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769318 ]
ASF GitHub Bot logged work on HADOOP-17864: ------------------------------------------- Author: ASF GitHub Bot Created on: 11/May/22 21:38 Start Date: 11/May/22 21:38 Worklog Time Spent: 10m Work Description: snvijaya commented on code in PR #3335: URL: https://github.com/apache/hadoop/pull/3335#discussion_r870775641 ########## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java: ########## @@ -159,12 +163,114 @@ public long getBytesReceived() { return bytesReceived; } - public ListResultSchema getListResultSchema() { - return listResultSchema; + + protected void setStatusCode(final int statusCode) { Review Comment: Yes, even when on Fastpath, driver will receive HttpStatus code and other relevant details for the corresponding request, this enables existing logic for retry/throttling handling to continue to work. Has to be on base class. ########## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java: ########## @@ -159,12 +163,114 @@ public long getBytesReceived() { return bytesReceived; } - public ListResultSchema getListResultSchema() { - return listResultSchema; + + protected void setStatusCode(final int statusCode) { + this.statusCode = statusCode; + } + + protected void setStatusDescription(final String statusDescription) { + this.statusDescription = statusDescription; + } + + protected void setStorageErrorCode(final String storageErrorCode) { + this.storageErrorCode = storageErrorCode; + } + + protected void setStorageErrorMessage(final String storageErrorMessage) { + this.storageErrorMessage = storageErrorMessage; + } + + protected void setRequestId(final String requestId) { + this.requestId = requestId; + } + + protected void setBytesSent(final int bytesSent) { + this.bytesSent = bytesSent; + } + + protected void setBytesReceived(final long bytesReceived) { + this.bytesReceived = bytesReceived; + } + + protected void setRecvResponseTimeMs(final long recvResponseTimeMs) { + this.recvResponseTimeMs = recvResponseTimeMs; + } + + protected long getRecvResponseTimeMs() { + return this.recvResponseTimeMs; + } + + protected void setAuthType(final org.apache.hadoop.fs.azurebfs.services.AuthType authType) { + this.authType = authType; + } + + protected void setAuthToken(final String authToken) { + this.authToken = authToken; + } + + protected void setResponseContentBuffer(final byte[] responseContentBuffer) { + this.responseContentBuffer = responseContentBuffer; + } + + protected void setAbfsHttpHeaders(final List<AbfsHttpHeader> abfsHttpHeaders) { + this.abfsHttpHeaders = abfsHttpHeaders; + } + + protected List<AbfsHttpHeader> getAbfsHttpHeaders() { + return abfsHttpHeaders; + } + + protected AbfsRestOperationType getOpType() { + return opType; + } + + protected URL getUrl() { + return url; + } + + protected boolean isTraceEnabled() { + return isTraceEnabled; } - public String getResponseHeader(String httpHeader) { - return connection.getHeaderField(httpHeader); + protected void setConnectionTimeMs(final long connectionTimeMs) { + this.connectionTimeMs = connectionTimeMs; + } + + protected void setSendRequestTimeMs(final long sendRequestTimeMs) { + this.sendRequestTimeMs = sendRequestTimeMs; + } + + protected void setExpectedAppendPos(final String expectedAppendPos) { Review Comment: Yes, expect this to be a field to be updated when on Fastpath later on. Hence retained on the abstract class. Issue Time Tracking ------------------- Worklog Id: (was: 769318) Time Spent: 2h 20m (was: 2h 10m) > ABFS: Fork AbfsHttpOperation to add alternate connection > -------------------------------------------------------- > > Key: HADOOP-17864 > URL: https://issues.apache.org/jira/browse/HADOOP-17864 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure > Affects Versions: 3.4.0 > Reporter: Sneha Vijayarajan > Assignee: Sneha Vijayarajan > Priority: Major > Labels: pull-request-available > Time Spent: 2h 20m > Remaining Estimate: 0h > > This Jira is to facilitate upcoming work as part of adding an alternate > connection : > [HADOOP-17853] ABFS: Enable optional store connectivity over azure specific > protocol for data egress - ASF JIRA (apache.org) > The scope of the change is to make AbfsHttpOperation as abstract class and > create a child class AbfsHttpConnection. Future connection types will be > added as child of AbfsHttpOperation. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org