saintstack commented on PR #4246: URL: https://github.com/apache/hadoop/pull/4246#issuecomment-1124514541
Removing a space had us run more tests and 4 tests failed instead of 44 on previous run. Below is the change in last run. ``` From eb904f3adaa55d44aa6494ad116344317e9ec882 Mon Sep 17 00:00:00 2001 From: stack <st...@apache.org> Date: Wed, 11 May 2022 15:42:18 -0700 Subject: [PATCH] Remove a space at end of line inside a comment -- non-change --- .../hadoop/hdfs/server/blockmanagement/DatanodeManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java index 4f74fe0c7364..1937e5d7acc3 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java @@ -1195,7 +1195,7 @@ public void registerDatanode(DatanodeRegistration nodeReg) } else { // nodeS is found /* - The registering datanode is a replacement node for the existing + The registering datanode is a replacement node for the existing data storage, which from now on will be served by a new node. If this message repeats, both nodes might have same storageID by (insanely rare) random chance. User needs to restart one of the ``` The tests that failed on this run: org.apache.hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS.testRead org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks.testSetRepIncWithUnderReplicatedBlocks org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery.testDnRestartWithSavedReplicas org.apache.hadoop.hdfs.server.namenode.ha.TestHAAppend.testMultipleAppendsDuringCatchupTailing do not overlap at all with the failures in the previous run. I see the branch-mvninstall-root failed with "unable to create new native thread" Let me try one more run shifting a space and see what I get. I don't think this patch has any relation to the failures I'm seeing. I'll merge unless I see an obvious relation in the next run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org