[
https://issues.apache.org/jira/browse/HADOOP-18266?focusedWorklogId=778553&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778553
]
ASF GitHub Bot logged work on HADOOP-18266:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/22 08:53
Start Date: 06/Jun/22 08:53
Worklog Time Spent: 10m
Work Description: aajisaka commented on code in PR #4365:
URL: https://github.com/apache/hadoop/pull/4365#discussion_r889951385
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:
##########
@@ -1442,7 +1441,7 @@ public static void destroyAllShellProcesses() {
*/
public static Set<Shell> getAllShells() {
synchronized (CHILD_SHELLS) {
- return new HashSet<>(CHILD_SHELLS.keySet());
+ return CHILD_SHELLS.keySet();
Review Comment:
I think the diff changes the behavior. Would you revert the change?
- Before: The method returns `HashSet`
- After: The method returns `SynchronizedSet` because `CHILD_SHELLS` is
`SynchronizedMap`.
Issue Time Tracking
-------------------
Worklog Id: (was: 778553)
Time Spent: 1h 10m (was: 1h)
> Replace with HashSet/TreeSet constructor in Hadoop-common-project
> -----------------------------------------------------------------
>
> Key: HADOOP-18266
> URL: https://issues.apache.org/jira/browse/HADOOP-18266
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: common
> Affects Versions: 3.3.4
> Reporter: Samrat Deb
> Assignee: Samrat Deb
> Priority: Trivial
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]