[
https://issues.apache.org/jira/browse/HADOOP-18284?focusedWorklogId=782261&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782261
]
ASF GitHub Bot logged work on HADOOP-18284:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jun/22 07:06
Start Date: 17/Jun/22 07:06
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #4422:
URL: https://github.com/apache/hadoop/pull/4422#discussion_r899824845
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java:
##########
@@ -516,7 +516,7 @@ private static String parameters2String(MyOptions options) {
}
private static class MyOptions {
- String rootDir = GenericTestUtils.getTestDir().getAbsolutePath();;
+ private String rootDir = GenericTestUtils.getTestDir().getAbsolutePath();;
Review Comment:
no need to add `private` here as part of this change
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/MapTask.java:
##########
@@ -930,7 +930,7 @@ private long getOutputBytes(List<Statistics> stats) {
// spill accounting
private int maxRec;
private int softLimit;
- boolean spillInProgress;;
+ private boolean spillInProgress;
Review Comment:
no need to add `private` here as part of this change
Issue Time Tracking
-------------------
Worklog Id: (was: 782261)
Time Spent: 1h 40m (was: 1.5h)
> Remove Unnecessary semicolon ';'
> ---------------------------------
>
> Key: HADOOP-18284
> URL: https://issues.apache.org/jira/browse/HADOOP-18284
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> while reading the code, I found a very tiny optimization point, part of the
> code contains 2 semicolons at the end, I will fix it. Because this change is
> simple, I fixed it in One JIRA.
> {code:java}
> private final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();;
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]