[
https://issues.apache.org/jira/browse/HADOOP-18303?focusedWorklogId=783344&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783344
]
ASF GitHub Bot logged work on HADOOP-18303:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/22 11:46
Start Date: 21/Jun/22 11:46
Worklog Time Spent: 10m
Work Description: ayushtkn commented on PR #4461:
URL: https://github.com/apache/hadoop/pull/4461#issuecomment-1161637780
>I'm getting really confused now. Before this PR, conflicting imports were
both being shaded. Now they are being merged in unshaded and the issue is which
ones not to shade?
I am also confused....
No, one was shaded one wasn't, the one not shaded is getting added here
because kirby & spark are crying due to missing classes.
The question is yes which one to shade and which one not to, In Ideal
situation only one these jars should be there because they provide similar
classes and to be used by different version.
In our case Jackson use the new Jar, and Jersey uses the old Jar, so we need
both Jar in hadoop. If we upgrade Jersey also, both Jackson & Jersey will need
the new jar and we can remove one jar and this conflict.
Let us assume we did something with the shading, but Projects like Tez, when
they add Hadoop as dependency they get both Jars and both have similar classes,
so that creates a mess, something similar error message like here:
https://stackoverflow.com/questions/23277429/java-lang-abstractmethoderror-javax-ws-rs-core-uribuilder-uri/26767488#26767488
Regarding Solution: I don't have a perfect solution, and definitely need
pointers, Not sure what we can do with shading, if we figure out may be
spark/kriby may be happy. But if we exclude the old jar who will be unhappy god
knows....
Shading won't solve Hive/Tez issue....
Jersey upgrade: Not sure we can do for a maintenance release, people have
objections for protobuf as well, and post that also I guess downstream also
have to upgrade Jersey, that won't be easy either.
That is all what I know or can think of, Not sure what all is Right/Wrong.
Hope I didn't contribute more to the confusion.....
Issue Time Tracking
-------------------
Worklog Id: (was: 783344)
Time Spent: 1h 10m (was: 1h)
> Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime
> ----------------------------------------------------------------------
>
> Key: HADOOP-18303
> URL: https://issues.apache.org/jira/browse/HADOOP-18303
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Critical
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> As part of HADOOP-18033, we have excluded shading of javax.ws.rs-api from
> both hadoop-client-runtime and hadoop-client-minicluster. This has caused
> issues for downstreamers e.g.
> [https://github.com/apache/incubator-kyuubi/issues/2904], more discussions.
> We should put the shading back in hadoop-client-runtime to fix CNFE issues
> for downstreamers.
> cc [~ayushsaxena] [~pan3793]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
