slfan1989 commented on PR #4422: URL: https://github.com/apache/hadoop/pull/4422#issuecomment-1162005008
Hi, @ayushtkn, Thank you very much for your help reviewing the code, I read the test report about the checkstyle issue. 1st ``` String rootDir = GenericTestUtils.getTestDir().getAbsolutePath();:12: Variable 'rootDir' must be private and have accessor methods. [VisibilityModifier] ``` 2nd ``` boolean spillInProgress;:13: Variable 'spillInProgress' must be private and have accessor methods. [VisibilityModifier] ``` These two places should not need to increase the private modifier. Please help me review the code again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
