Hexiaoqiao commented on PR #4524: URL: https://github.com/apache/hadoop/pull/4524#issuecomment-1173346196
@ZanderXu @ayushtkn, Thanks for your great works here. After a quick glance, it seems one solution to improve renewLease for RBF. I would like to share my practice for this issue. I also meet this renewLease performance issue when upgrade to RBF architecture. When I observed that renewLease request count to NameNode grew unexpected and time cost obviously, I try to analysis if it is possible to bring file path as one parameter to renewLease. After collect `create` and `renewLease` audit, there are less than 3% renewLease requests to renew different files lease for one client (generally less than 5 files) in our data warehouse scenario (Maybe it is not true for other scenarios). Then I try to add a new interface `public void renewLease(String path, String clientName)` and route request based on `path` at Router side which is common logic. Just propose another choice for this improvement. This is not objection for this PR, just another solution for discussion. If we have reached agreement, I would like to give deep reviews. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
