[
https://issues.apache.org/jira/browse/HADOOP-18329?focusedWorklogId=789404&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-789404
]
ASF GitHub Bot logged work on HADOOP-18329:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jul/22 08:39
Start Date: 11/Jul/22 08:39
Worklog Time Spent: 10m
Work Description: JackBuggins commented on code in PR #4537:
URL: https://github.com/apache/hadoop/pull/4537#discussion_r917681111
##########
hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/util/PlatformName.java:
##########
@@ -45,9 +45,34 @@ public class PlatformName {
/**
* A public static variable to indicate the current java vendor is
- * IBM java or not.
+ * IBM and the type is Java Technology Edition which provides its
+ * own implementations of many security packages and Cipher suites.
+ * Note that these are not provided in Semeru runtimes:
+ * See https://developer.ibm.com/languages/java/semeru-runtimes/
*/
- public static final boolean IBM_JAVA = JAVA_VENDOR_NAME.contains("IBM");
+ public static final boolean USE_IBM_JAVA_PACKAGES = shouldUseIbmPackages();
+
+ /*
+ * IBM_JAVA must be preserved due to the public nature of the property.
+ */
+ @Deprecated
+ public static final boolean IBM_JAVA = USE_IBM_JAVA_PACKAGES;
Review Comment:
Thanks you for the review @steveloughran - I have pushed up another commit
implementing this suggestion, I am happy to keep it as is - my initial thoughts
were that the symbols meaning has changed, but the adjustments in the comments
should be sufficient to keep it clear whilst not changing as many files or
requiring the deprecation.
Issue Time Tracking
-------------------
Worklog Id: (was: 789404)
Remaining Estimate: 20m (was: 0.5h)
Time Spent: 40m (was: 0.5h)
> Add support for IBM Semeru OE JRE 11.0.15.0 and greater
> -------------------------------------------------------
>
> Key: HADOOP-18329
> URL: https://issues.apache.org/jira/browse/HADOOP-18329
> Project: Hadoop Common
> Issue Type: Bug
> Components: auth, common
> Affects Versions: 3.0.0, 3.1.0, 3.0.1, 3.2.0, 3.0.2, 3.1.1, 3.0.3, 3.3.0,
> 3.1.2, 3.2.1, 3.1.3, 3.1.4, 3.2.2, 3.3.1, 3.2.3, 3.3.2, 3.3.3
> Environment: Running Hadoop (or Apache Spark 3.2.1 or above) on IBM
> Semeru runtimes open edition 11.0.15.0 or greater.
> Reporter: Jack
> Priority: Major
> Labels: pull-request-available
> Original Estimate: 1h
> Time Spent: 40m
> Remaining Estimate: 20m
>
> There are checks within the PlatformName class that use the Vendor property
> of the provided runtime JVM specifically looking for `IBM` within the name.
> Whilst this check worked for IBM's [java technology
> edition|https://www.ibm.com/docs/en/sdk-java-technology] it fails to work on
> [Semeru|https://developer.ibm.com/languages/java/semeru-runtimes/] since
> 11.0.15.0 due to the following change:
> h4. java.vendor system property
> In this release, the {{java.vendor}} system property has been changed from
> "International Business Machines Corporation" to "IBM Corporation".
> Modules such as the below are not provided in these runtimes.
> com.ibm.security.auth.module.JAASLoginModule
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
