goiri commented on code in PR #4543: URL: https://github.com/apache/hadoop/pull/4543#discussion_r918197490
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java: ########## @@ -1336,7 +1336,51 @@ public AppAttemptInfo getAppAttempt(HttpServletRequest req, @Override public ContainersInfo getContainers(HttpServletRequest req, HttpServletResponse res, String appId, String appAttemptId) { - throw new NotImplementedException("Code is not implemented"); + ContainersInfo containersInfo = new ContainersInfo(); + + Map<SubClusterId, SubClusterInfo> subClustersActive = null; + try { + subClustersActive = federationFacade.getSubClusters(true); + } catch (YarnException e) { + LOG.error(e.getLocalizedMessage()); Review Comment: Are we OK just swallowing this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org