steveloughran commented on code in PR #4255:
URL: https://github.com/apache/hadoop/pull/4255#discussion_r918827783
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java:
##########
@@ -204,6 +204,20 @@ public static void resetFirstHaltException() {
FIRST_HALT_EXCEPTION.set(null);
}
+ /**
+ * Suppresses if legit and returns the first non-null of the two. Legit means
+ * <code>suppressor</code> if neither <code>null</code> nor
<code>suppressed</code>.
+ */
+ private static <T extends Throwable> T addSuppressed(T suppressor, T
suppressed) {
Review Comment:
nice!
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ExitUtil.java:
##########
@@ -204,6 +204,20 @@ public static void resetFirstHaltException() {
FIRST_HALT_EXCEPTION.set(null);
}
+ /**
+ * Suppresses if legit and returns the first non-null of the two. Legit means
+ * <code>suppressor</code> if neither <code>null</code> nor
<code>suppressed</code>.
+ */
Review Comment:
can you add some params to the javadoc to keep it happy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
