slfan1989 commented on code in PR #4540:
URL: https://github.com/apache/hadoop/pull/4540#discussion_r920744972
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestRouterYarnClientUtils.java:
##########
@@ -539,4 +532,73 @@ public void testMergeResourceTypes() {
Assert.assertTrue(CollectionUtils.isEqualCollection(expectedResponse,
response.getResourceTypeInfo()));
}
+
+ @Test
+ public void testMergeResourceProfiles() {
+ // normal response1
+ Map<String, Resource> profiles = new HashMap<>();
+ Resource resource1 = Resource.newInstance(1024, 1);
+ GetAllResourceProfilesResponse response1 =
GetAllResourceProfilesResponse.newInstance();
+ profiles.put("maximum", resource1);
+ response1.setResourceProfiles(profiles);
+
+ // normal response2
+ profiles = new HashMap<>();
+ Resource resource2 = Resource.newInstance(2048, 2);
+ GetAllResourceProfilesResponse response2 =
GetAllResourceProfilesResponse.newInstance();
+ profiles.put("maximum", resource2);
+ response2.setResourceProfiles(profiles);
+
+ // empty response
+ GetAllResourceProfilesResponse response3 =
GetAllResourceProfilesResponse.newInstance();
+
+ // null response
+ GetAllResourceProfilesResponse response4 = null;
+
+ List<GetAllResourceProfilesResponse> responses = new ArrayList<>();
+ responses.add(response1);
+ responses.add(response2);
+ responses.add(response3);
+ responses.add(response4);
+
+ GetAllResourceProfilesResponse response =
+ RouterYarnClientUtils.mergeClusterResourceProfilesResponse(responses);
+ Resource resource = response.getResourceProfiles().get("maximum");
+ Assert.assertEquals(resource.getVirtualCores(), 3);
+ Assert.assertEquals(resource.getMemorySize(), 3072);
+ }
+
+ @Test
+ public void testMergeResourceProfile() {
+ // normal response1
+ Resource resource1 = Resource.newInstance(1024, 1);
+ GetResourceProfileResponse response1 =
+ Records.newRecord(GetResourceProfileResponse.class);
+ response1.setResource(resource1);
+
+ // normal response2
+ Resource resource2 = Resource.newInstance(2048, 2);
+ GetResourceProfileResponse response2 =
+ Records.newRecord(GetResourceProfileResponse.class);
+ response2.setResource(resource2);
+
+ // empty response
+ GetResourceProfileResponse response3 =
+ Records.newRecord(GetResourceProfileResponse.class);
+
+ // null response
+ GetResourceProfileResponse response4 = null;
+
+ List<GetResourceProfileResponse> responses = new ArrayList<>();
+ responses.add(response1);
+ responses.add(response2);
+ responses.add(response3);
+ responses.add(response4);
+
+ GetResourceProfileResponse response =
+ RouterYarnClientUtils.mergeClusterResourceProfileResponse(responses);
+ Resource resource = response.getResource();
+ Assert.assertEquals(resource.getVirtualCores(), 3);
Review Comment:
Thanks for the suggestion, I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
