slfan1989 commented on code in PR #4543:
URL: https://github.com/apache/hadoop/pull/4543#discussion_r922600402
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestFederationInterceptorREST.java:
##########
@@ -560,4 +563,49 @@ SubClusterState.SC_RUNNING, new MonotonicClock().getTime(),
SubClusterRegisterRequest.newInstance(subClusterInfo));
}
+ @Test
+ public void testGetContainers()
+ throws YarnException, IOException, InterruptedException {
+
+ ApplicationId appId = ApplicationId.newInstance(Time.now(), 1);
+ ApplicationSubmissionContextInfo context =
Review Comment:
I will fix it.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestFederationInterceptorREST.java:
##########
@@ -560,4 +563,49 @@ SubClusterState.SC_RUNNING, new MonotonicClock().getTime(),
SubClusterRegisterRequest.newInstance(subClusterInfo));
}
+ @Test
+ public void testGetContainers()
+ throws YarnException, IOException, InterruptedException {
+
+ ApplicationId appId = ApplicationId.newInstance(Time.now(), 1);
+ ApplicationSubmissionContextInfo context =
+ new ApplicationSubmissionContextInfo();
+ context.setApplicationId(appId.toString());
+
+ // Submit the application we want the report later
+ Response response = interceptor.submitApplication(context, null);
+
+ Assert.assertNotNull(response);
+ Assert.assertNotNull(stateStoreUtil.queryApplicationHomeSC(appId));
+
+ ApplicationAttemptId appAttempt =
+ ApplicationAttemptId.newInstance(appId, 1);
+
+ ContainersInfo responseGet = interceptor.getContainers(null, null,
+ appId.toString(), appAttempt.toString());
+
+ Assert.assertEquals(4, responseGet.getContainers().size());
+ }
+
+ @Test
+ public void testGetContainersNotExists() {
+ ApplicationId appId = ApplicationId.newInstance(Time.now(), 1);
+ ContainersInfo response =
Review Comment:
I will fix it.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestFederationInterceptorREST.java:
##########
@@ -560,4 +563,49 @@ SubClusterState.SC_RUNNING, new MonotonicClock().getTime(),
SubClusterRegisterRequest.newInstance(subClusterInfo));
}
+ @Test
+ public void testGetContainers()
+ throws YarnException, IOException, InterruptedException {
+
+ ApplicationId appId = ApplicationId.newInstance(Time.now(), 1);
+ ApplicationSubmissionContextInfo context =
+ new ApplicationSubmissionContextInfo();
+ context.setApplicationId(appId.toString());
+
+ // Submit the application we want the report later
+ Response response = interceptor.submitApplication(context, null);
+
+ Assert.assertNotNull(response);
+ Assert.assertNotNull(stateStoreUtil.queryApplicationHomeSC(appId));
+
+ ApplicationAttemptId appAttempt =
+ ApplicationAttemptId.newInstance(appId, 1);
+
+ ContainersInfo responseGet = interceptor.getContainers(null, null,
+ appId.toString(), appAttempt.toString());
+
+ Assert.assertEquals(4, responseGet.getContainers().size());
+ }
+
+ @Test
+ public void testGetContainersNotExists() {
+ ApplicationId appId = ApplicationId.newInstance(Time.now(), 1);
+ ContainersInfo response =
+ interceptor.getContainers(null, null, appId.toString(), null);
+ Assert.assertTrue(response.getContainers().isEmpty());
+ }
+
+ @Test
+ public void testGetContainersWrongFormat() {
+ ContainersInfo response =
Review Comment:
I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
