[ 
https://issues.apache.org/jira/browse/HADOOP-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195174#comment-13195174
 ] 

Robert Joseph Evans commented on HADOOP-7998:
---------------------------------------------

Your patch looks good +1.  I looked at the javadoc warnings and they are

{noformat}
[WARNING] 
/home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java:21:
 warning: sun.security.jgss.GSSUtil is Sun proprietary API and may be removed 
in a future release
[WARNING] 
/home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:30:
 warning: sun.security.krb5.Config is Sun proprietary API and may be removed in 
a future release
[WARNING] 
/home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:31:
 warning: sun.security.krb5.KrbException is Sun proprietary API and may be 
removed in a future release
[WARNING] 
/home/evans/src/commit/trunk/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:80:
 warning: sun.security.krb5.Config is Sun proprietary API and may be removed in 
a future release
[WARNING] 
/home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java:28:
 warning: sun.security.krb5.Config is Sun proprietary API and may be removed in 
a future release
[WARNING] 
/home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java:29:
 warning: sun.security.krb5.KrbException is Sun proprietary API and may be 
removed in a future release
[WARNING] 
/home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:49:
 warning: sun.net.dns.ResolverConfiguration is Sun proprietary API and may be 
removed in a future release
[WARNING] 
/home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:50:
 warning: sun.net.util.IPAddressUtil is Sun proprietary API and may be removed 
in a future release
[WARNING] 
/home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:51:
 warning: sun.security.jgss.krb5.Krb5Util is Sun proprietary API and may be 
removed in a future release
[WARNING] 
/home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:52:
 warning: sun.security.krb5.Credentials is Sun proprietary API and may be 
removed in a future release
[WARNING] 
/home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:53:
 warning: sun.security.krb5.PrincipalName is Sun proprietary API and may be 
removed in a future release
[WARNING] 
/home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:25:
 warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future 
release
[WARNING] 
/home/evans/src/commit/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:117:
 warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future 
release
{noformat}

All of them look like acceptable usage, and the first 6 kerberos ones are 
already ignored so I will bump the javadoc warning number as part of the commit.
                
> CheckFileSystem does not correctly honor setVerifyChecksum
> ----------------------------------------------------------
>
>                 Key: HADOOP-7998
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7998
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7998-2.patch, HADOOP-7998.patch
>
>
> Regardless of the verify checksum flag, {{ChecksumFileSystem#open}} will 
> instantiate a {{ChecksumFSInputChecker}} instead of a normal stream.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to