huaxiangsun commented on code in PR #4608:
URL: https://github.com/apache/hadoop/pull/4608#discussion_r932404324
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:
##########
@@ -3800,6 +3819,32 @@ UploadResult waitForUploadCompletion(String key,
UploadInfo uploadInfo)
}
}
+
+ /**
+ * Delete all paths that were marked as delete-on-exit. This recursively
+ * deletes all files and directories in the specified paths. It does not
+ * check if file exists and filesystem is closed.
+ *
+ * The time to process this operation is {@code O(paths)}, with the actual
+ * time dependent on the time for existence and deletion operations to
+ * complete, successfully or not.
+ */
+ @Override
+ protected void processDeleteOnExit() {
+ Set<Path> deleteOnExit = getDeleteOnExitSet();
+ synchronized (deleteOnExit) {
+ for (Iterator<Path> iter = deleteOnExit.iterator(); iter.hasNext();) {
+ Path path = iter.next();
+ try {
+ deleteWithoutCloseCheck(path, true);
+ } catch (IOException e) {
+ LOG.info("Ignoring failure to deleteOnExit for path {}, exception
{}", path, e);
Review Comment:
Makes sense, will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
