[
https://issues.apache.org/jira/browse/HADOOP-18340?focusedWorklogId=797418&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797418
]
ASF GitHub Bot logged work on HADOOP-18340:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/22 22:10
Start Date: 02/Aug/22 22:10
Worklog Time Spent: 10m
Work Description: huaxiangsun commented on PR #4608:
URL: https://github.com/apache/hadoop/pull/4608#issuecomment-1203263503
Thanks @steveloughran for all the helps. I pushed a new patch, which I hope
addresses your comments.
1. Undo the changes in FileSystem.java, code is duplicated in S3AFileSystem.
2. Incorporated some of your changes in
[HADOOP-13611](https://issues.apache.org/jira/browse/HADOOP-13611)
3. Added a new s3a integration test case for deleteOnExit.
I have run all integration test under hadoop-aws. Here are the results.
<div id="breadcrumbs" style="font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; text-align: start; text-indent:
0px; text-transform: none; white-space: normal; word-spacing: 0px;
-webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;
text-decoration: none; color: rgb(0, 0, 0); font-family: Times; font-size:
medium; font-variant-ligatures: normal; orphans: 2; widows: 2;
text-decoration-thickness: initial;"><div class="xleft"><span
id="publishDate">Last Published: 2022-08-02</span> | <span
id="projectVersion">Version: 3.4.0-SNAPSHOT</span></div><div
class="xright"></div><div class="clear"><hr></div></div><div id="leftColumn"
style="font-style: normal; font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; text-decoration: none; color: rgb(0, 0, 0);
font-family: Times; font-size: medium; font-variant-ligatures: normal; orphans:
2; widows: 2; text-decoration-thickness: initial;"><div id="navcolumn"><a
href="http://maven.apache.org/"; title="Built by Maven" class="poweredBy"
style="color: var(--accent-color) !important; text-decoration: underline
!important; -apple-color-filter: none;"></a></div></div><div id="bodyColumn"
style="font-style: normal; font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; text-decoration: none; color: rgb(0, 0, 0);
font-family: Times; font-size: medium; font-variant-ligatures: normal; orphans:
2; widows: 2; text-decoration-thickness: initial;"><div
id="contentBox"><section><h2><a name="Failsafe_Report" style="color: rgb(158,
75, 47); text-decoration: underline !important;"></a>Failsafe
Report</h2></section><section><h2><a name="Summary" style="color: rgb(158, 75,
47); text-decoration: underline !important;"></a>Summary</h2><a name="Summary"
style="color: rgb(158, 75, 47); text-decoration: underline
!important;"></a><p>[<a style="color: rgb(158, 75, 47); text-decoration:
underline !important;">Summary</a>] [<a style="color: rgb(158, 75, 47);
text-decoration: underline !important;">Package List</a>] [<a style="color:
rgb(158, 75, 47); text-decoration: underline !important;">Test
Cases</a>]</p><br>
Tests | Errors | Failures | Skipped | Success Rate | Time
Issue Time Tracking
-------------------
Worklog Id: (was: 797418)
Time Spent: 2h 10m (was: 2h)
> deleteOnExit does not work with S3AFileSystem
> ---------------------------------------------
>
> Key: HADOOP-18340
> URL: https://issues.apache.org/jira/browse/HADOOP-18340
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/s3
> Affects Versions: 3.3.3
> Reporter: Huaxiang Sun
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> When deleteOnExit is set on some paths, they are not removed when file system
> object is closed. The following exception is logged when printing out the
> exception in info log.
> {code:java}
> 2022-07-15 19:29:12,552 [main] INFO fs.FileSystem
> (FileSystem.java:processDeleteOnExit(1810)) - Ignoring failure to
> deleteOnExit for path /file, exception {}
> java.io.IOException: s3a://mock-bucket: FileSystem is closed!
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.checkNotClosed(S3AFileSystem.java:3887)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.trackDurationAndSpan(S3AFileSystem.java:2333)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.trackDurationAndSpan(S3AFileSystem.java:2355)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.exists(S3AFileSystem.java:4402)
> at
> org.apache.hadoop.fs.FileSystem.processDeleteOnExit(FileSystem.java:1805)
> at org.apache.hadoop.fs.FileSystem.close(FileSystem.java:2669)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.close(S3AFileSystem.java:3830)
> at
> org.apache.hadoop.fs.s3a.TestS3AGetFileStatus.testFile(TestS3AGetFileStatus.java:87)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at
> org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> at
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
