steveloughran commented on code in PR #4677:
URL: https://github.com/apache/hadoop/pull/4677#discussion_r936481442
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java:
##########
@@ -171,35 +171,6 @@ public static PathFilter getInputPathFilter(JobConf conf) {
ReflectionUtils.newInstance(filterClass, conf) : null;
}
- /**
- * Add files in the input path recursively into the results.
- * @param result
- * The List to store all files.
- * @param fs
- * The FileSystem.
- * @param path
- * The input path.
- * @param inputFilter
- * The input filter that can be used to filter files/dirs.
- * @throws IOException
- */
- protected void addInputPathRecursively(List<FileStatus> result,
Review Comment:
you can't remove this as it breaks methods external classes may use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
