[
https://issues.apache.org/jira/browse/HADOOP-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eli Collins updated HADOOP-7938:
--------------------------------
Attachment: hadoop-7938.txt
Thanks for the review Todd. Updated patch applies atop HADOOP-7983.
- Made failover require a fencer. Reasonable IMO since we can't safely failover
w/o fencing, and users can workaround with an "exit 1" shell fencer if they
only want cooperative failover.
- transitionToStandby and active are nops if the service is already in that
state, which I think is the right behavior. Added a test to
TestHAStateTransitions to cover this.
- force-fence no longer has to be the last argument. I had to rename it
"forcefence" since options can't have dashes. Note also that it can't be the
very first argument because HAAdmin considers those commands. Perhaps we should
update HAAdmin to not prefix commands with a dash?
- Whitespace in NodeFencer.java is to make the if clause consistent with the
following one, if you don't mind I'll keep it
- FC uses failover recursively for failback, definitely better!
- Added NodeFencer#create
> HA: the FailoverController should optionally fence the active during failover
> -----------------------------------------------------------------------------
>
> Key: HADOOP-7938
> URL: https://issues.apache.org/jira/browse/HADOOP-7938
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: HA Branch (HDFS-1623)
>
> Attachments: hadoop-7938.txt, hadoop-7938.txt, hadoop-7938.txt
>
>
> The FailoverController in HADOOP-7924 needs to be able to fence off the
> current active in case it fails to transition to standby (or the user
> requests it for sanity). This is needed even for manual failover (the CLI
> should use the configured fencing mechanism). The FC needs to access the
> HDFS-specific implementations HDFS-2179, could add a common fencing interface
> (or just shell out but we may not always want to do that).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
