[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #4690: HADOOP-18181. Move prefetch common classes to hadoop common

[GitBox]

mukund-thakur commented on code in PR #4690:
URL: https://github.com/apache/hadoop/pull/4690#discussion_r938221909


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/BlockOperations.java:
##########
@@ -163,61 +163,61 @@ private synchronized Operation add(Operation op) {
   public Operation getPrefetched(int blockNumber) {
     Validate.checkNotNegative(blockNumber, "blockNumber");
 
-    return this.add(new Operation(Kind.GET_PREFETCHED, blockNumber));
+    return add(new Operation(Kind.GET_PREFETCHED, blockNumber));
   }
 
   public Operation getCached(int blockNumber) {
     Validate.checkNotNegative(blockNumber, "blockNumber");
 
-    return this.add(new Operation(Kind.GET_CACHED, blockNumber));
+    return add(new Operation(Kind.GET_CACHED, blockNumber));
   }
 
   public Operation getRead(int blockNumber) {
     Validate.checkNotNegative(blockNumber, "blockNumber");
 
-    return this.add(new Operation(Kind.GET_READ, blockNumber));
+    return add(new Operation(Kind.GET_READ, blockNumber));
   }
 
   public Operation release(int blockNumber) {
     Validate.checkNotNegative(blockNumber, "blockNumber");

Review Comment:
   static import here as well like other places above.
   import static org.apache.hadoop.fs.impl.prefetch.Validate.checkNotNegative; 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org