goiri commented on PR #4660: URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1215773135
> @slfan1989 Thanks for your review. > > > Do we need to update the md file to explain what these parameters do? > > Do you mean which MD file? `ipc.client.rpc-timeout.ms` is not been explained. If you think we should do it, I will add some explanation for them. I'm not sure what is the best place to document. TBH, I do not see a good place to document this; so it might be best to just have it in the XML. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
