goiri commented on code in PR #4738:
URL: https://github.com/apache/hadoop/pull/4738#discussion_r947214942
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.java:
##########
@@ -104,29 +107,39 @@
public class ZookeeperFederationStateStore implements FederationStateStore {
private static final Logger LOG =
- LoggerFactory.getLogger(ZookeeperFederationStateStore.class);
+ LoggerFactory.getLogger(ZookeeperFederationStateStore.class);
Review Comment:
Avoid
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.java:
##########
@@ -104,29 +107,39 @@
public class ZookeeperFederationStateStore implements FederationStateStore {
private static final Logger LOG =
- LoggerFactory.getLogger(ZookeeperFederationStateStore.class);
+ LoggerFactory.getLogger(ZookeeperFederationStateStore.class);
private final static String ROOT_ZNODE_NAME_MEMBERSHIP = "memberships";
private final static String ROOT_ZNODE_NAME_APPLICATION = "applications";
private final static String ROOT_ZNODE_NAME_POLICY = "policies";
- /** Interface to Zookeeper. */
+ /**
+ * Interface to Zookeeper.
Review Comment:
The old format is common; I would leave it as is
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.java:
##########
@@ -203,53 +217,58 @@ public AddApplicationHomeSubClusterResponse
addApplicationHomeSubCluster(
FederationStateStoreUtils.logAndThrowStoreException(LOG, errMsg);
}
SubClusterId newSubClusterId =
- request.getApplicationHomeSubCluster().getHomeSubCluster();
+ request.getApplicationHomeSubCluster().getHomeSubCluster();
Review Comment:
This new spacing is wrong.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.java:
##########
@@ -104,29 +107,39 @@
public class ZookeeperFederationStateStore implements FederationStateStore {
private static final Logger LOG =
- LoggerFactory.getLogger(ZookeeperFederationStateStore.class);
+ LoggerFactory.getLogger(ZookeeperFederationStateStore.class);
private final static String ROOT_ZNODE_NAME_MEMBERSHIP = "memberships";
private final static String ROOT_ZNODE_NAME_APPLICATION = "applications";
private final static String ROOT_ZNODE_NAME_POLICY = "policies";
- /** Interface to Zookeeper. */
+ /**
+ * Interface to Zookeeper.
+ */
private ZKCuratorManager zkManager;
- /** Directory to store the state store data. */
+ /**
+ * Directory to store the state store data.
+ */
private String baseZNode;
private String appsZNode;
private String membershipZNode;
private String policiesZNode;
+ private volatile Clock clock = SystemClock.getInstance();
+
+ @VisibleForTesting
+ private ZKFederationStateStoreOpDurations opDurations =
+ ZKFederationStateStoreOpDurations.getInstance();
+
@Override
public void init(Configuration conf) throws YarnException {
LOG.info("Initializing ZooKeeper connection");
baseZNode = conf.get(
- YarnConfiguration.FEDERATION_STATESTORE_ZK_PARENT_PATH,
- YarnConfiguration.DEFAULT_FEDERATION_STATESTORE_ZK_PARENT_PATH);
+ YarnConfiguration.FEDERATION_STATESTORE_ZK_PARENT_PATH,
Review Comment:
This was fine before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
