[ https://issues.apache.org/jira/browse/HADOOP-18408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581403#comment-17581403 ]
ASF GitHub Bot commented on HADOOP-18408: ----------------------------------------- pranavsaxena-microsoft commented on code in PR #4758: URL: https://github.com/apache/hadoop/pull/4758#discussion_r949289883 ########## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/TestRenameStageFailure.java: ########## @@ -121,6 +121,7 @@ protected boolean requireRenameResilience() { @Test public void testResilienceAsExpected() throws Throwable { + Assume.assumeTrue(etagsPreserved); Review Comment: What if its HNS account and etags are not preserved due to code-issue, this test will be ignored. Is it possible to know if its non-HNS account and then ignore on basis of that? > [ABFS]: Ignore run of ITestAbfsRenameStageFailure for NonHNS-SharedKey > configuration > ------------------------------------------------------------------------------------ > > Key: HADOOP-18408 > URL: https://issues.apache.org/jira/browse/HADOOP-18408 > Project: Hadoop Common > Issue Type: Bug > Components: fs/azure, test > Reporter: Pranav Saxena > Assignee: Sree Bhattacharyya > Priority: Minor > Labels: pull-request-available > > ITestAbfsRenameStageFailure fails for NonHNS-SharedKey configuration. > Failure: > [ERROR] > ITestAbfsRenameStageFailure>TestRenameStageFailure.testResilienceAsExpected:126 > [resilient commit support] expected:<[tru]e> but was:<[fals]e> > RCA: > ResilientCommit looks for whether etags are preserved in rename, if not then > it throws an exception and the flag for resilientCommitByRename stays null, > leading ultimately to the test failure > Mitigation: > Since, etags are not preserved in the case of rename in nonHNS account, test > run for nonHNS account is not valid case. Hence, as part of this task, we > shall ignore this test for nonHNS configuraiton. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org