ayushtkn commented on code in PR #4678:
URL: https://github.com/apache/hadoop/pull/4678#discussion_r950919833


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/ServiceScheduler.java:
##########
@@ -1139,7 +1139,7 @@ public void syncSysFs(Service yarnApp) {
         LOG.info("YARN sysfs synchronized.");
       }
     } catch (IOException | URISyntaxException | InterruptedException e) {
-      LOG.error("Fail to sync service spec: {}", e);
+      LOG.error("Fail to sync service spec: {}", e.getMessage(), e);

Review Comment:
   No need to keep the message, just e is enough 



##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestServiceAM.java:
##########
@@ -553,7 +553,7 @@ public void testSyncSysFS() {
       am.stop();
       am.close();
     } catch (Exception e) {
-      LOG.error("Fail to sync sysfs: {}", e);
+      LOG.error("Fail to sync sysfs: {}", e.getMessage(), e);

Review Comment:
   Keep only e, message will come as part of that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to