PrabhuJoseph commented on code in PR #4742: URL: https://github.com/apache/hadoop/pull/4742#discussion_r951007590
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java: ########## @@ -350,6 +384,14 @@ public int launchContainer(ContainerStartContext ctx) return exitCode; } finally { if (shExec != null) shExec.close(); + try { Review Comment: Shall we use the same postComplete method here as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org