steveloughran commented on PR #4698: URL: https://github.com/apache/hadoop/pull/4698#issuecomment-1222593771
Looks good. Be aware that in CDP we will not backport this without the logs disabled, unless/until we have our own code all happy, which will involve a move to the v2 sdk elsewhere (STS interaction). ### getClient() the s3a FS class has a getClient() call too, which is only used internally or in external code which is doing things to get at it (the forTesting() one came in later, see). The internal stuff could make that private and instead pass it in to WriteOperationsHelper. really that class should 1. have the Select operation moved to its own interface and used exclusively by SelectBinding 2. have an interface of all the ops it is allowed to call on the s3a fs. None of our subsidiary classes should have direct refs to the owning fs; it just complicates our life too much. seemed a good idea at the time though... what does that mean for that patch? nothing, except by moving the (split) callbacks into two interfaces/impls. that getClient call could be made private and migration would be easier. ## datatypes Does the migration also mean that all the datatypes, s3Object, multipart input stream etc are all going to go too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
