ashutoshcipher commented on PR #4248: URL: https://github.com/apache/hadoop/pull/4248#issuecomment-1224052518
Thanks @steveloughran for checking. > Inconsistent synchronization of org.apache.hadoop.mapred.lib.MultipleOutputs.recordWriters; locked 66% of time Unsynchronized access at MultipleOutputs.java:66% of time Unsynchronized access at MultipleOutputs.java:[line 412] Here - This is due to this method which is only visible for testing and not to be used by actual prod code. ``` @VisibleForTesting public void setRecordWriters(Map<String, RecordWriter> recordWriters) { this.recordWriters = recordWriters; } ``` > Inconsistent synchronization of org.apache.hadoop.mapreduce.lib.output.MultipleOutputs.recordWriters; locked 66% of time Unsynchronized access at MultipleOutputs.java:66% of time Unsynchronized access at MultipleOutputs.java:[line 360] Here, This is also due to same method which is only visible for testing and not to be used by actual prod code. I missed marking it as `VisibleForTesting` which I will do in next commit. ``` public void setRecordWriters(Map<String, RecordWriter<?, ?>> recordWriters) { this.recordWriters = recordWriters; } ``` Let me know if I need to address anything else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org