Hexiaoqiao commented on code in PR #4761:
URL: https://github.com/apache/hadoop/pull/4761#discussion_r952681531
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java:
##########
@@ -73,7 +73,8 @@ public abstract class INode implements INodeAttributes,
Diff.Element<byte[]> {
* Check whether this is the root inode.
*/
final boolean isRoot() {
- return getLocalNameBytes().length == 0;
+ // Note: There is no restriction that id must be equal to
INodeId#ROOT_INODE_ID
+ return getLocalNameBytes() == null || getLocalNameBytes().length == 0;
Review Comment:
Got it. If that is true, I think we should submit PR to branch FGL first?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
