virajjasani commented on PR #4796:
URL: https://github.com/apache/hadoop/pull/4796#issuecomment-1226578101

   @steveloughran i also tested the entire test suite by enabling prefatch. 
Tests in `ITestS3AContractVectoredRead` failed. One example:
   ```
   [ERROR] testMinSeekAndMaxSizeDefaultValues[Buffer type : 
direct](org.apache.hadoop.fs.contract.s3a.ITestS3AContractVectoredRead)  Time 
elapsed: 13.025 s  <<< FAILURE!
   org.junit.ComparisonFailure: [Mismatch in default s3a min seek for vectored 
reads] expected:<4[8]96> but was:<4[0]96>
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at org.apache.hadoop.test.MoreAsserts.assertEqual(MoreAsserts.java:99)
        at 
org.apache.hadoop.fs.contract.s3a.ITestS3AContractVectoredRead.testMinSeekAndMaxSizeDefaultValues(ITestS3AContractVectoredRead.java:111)
   
   ```
   
   However, the failures don't seem relevant to the change on this PR. As per 
the test logic, it seems`ITestS3AContractVectoredRead` failures are expected 
when prefetch is enabled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to