[
https://issues.apache.org/jira/browse/HADOOP-18186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584745#comment-17584745
]
ASF GitHub Bot commented on HADOOP-18186:
-----------------------------------------
steveloughran commented on code in PR #4796:
URL: https://github.com/apache/hadoop/pull/4796#discussion_r954772825
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:
##########
@@ -776,7 +776,14 @@ private void initThreadPools(Configuration conf) {
executorCapacity = intOption(conf,
EXECUTOR_CAPACITY, DEFAULT_EXECUTOR_CAPACITY, 1);
if (this.prefetchEnabled) {
Review Comment:
can you cut the this. from here and the line below. not something we do in
the hadoop code except in constructors and setters
> s3a prefetching to use SemaphoredDelegatingExecutor for submitting work
> -----------------------------------------------------------------------
>
> Key: HADOOP-18186
> URL: https://issues.apache.org/jira/browse/HADOOP-18186
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
>
> Use SemaphoredDelegatingExecutor for each to stream to submit work, if
> possible, for better fairness in processes with many streams.
> this also takes a DurationTrackerFactory to count how long was spent in the
> queue, something we would want to know
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
