slfan1989 commented on code in PR #4846: URL: https://github.com/apache/hadoop/pull/4846#discussion_r962108019
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/MemoryFederationStateStore.java: ########## @@ -255,14 +261,33 @@ public GetApplicationHomeSubClusterResponse getApplicationHomeSubCluster( @Override public GetApplicationsHomeSubClusterResponse getApplicationsHomeSubCluster( GetApplicationsHomeSubClusterRequest request) throws YarnException { - List<ApplicationHomeSubCluster> result = - new ArrayList<ApplicationHomeSubCluster>(); - for (Entry<ApplicationId, SubClusterId> e : applications.entrySet()) { - result - .add(ApplicationHomeSubCluster.newInstance(e.getKey(), e.getValue())); + + if (request == null) { + throw new YarnException("Missing getApplicationsHomeSubCluster request"); + } + + List<ApplicationHomeSubCluster> result = new ArrayList<>(); + List<ApplicationId> applicationIdList = + applications.keySet().stream().collect(Collectors.toList()); + + SubClusterId requestSubClusterId = request.getSubClusterId(); + int appCount = 0; + for (int i = 0; i < applicationIdList.size(); i++) { + if (appCount >= maxAppsInStateStore) { + break; + } + ApplicationId applicationId = applicationIdList.get(i); + SubClusterId subClusterId = applications.get(applicationId); + // If the requestSubClusterId that needs to be filtered in the request + // is inconsistent with the SubClusterId in the data, continue to the next round + if (requestSubClusterId != null && !requestSubClusterId.equals(subClusterId)){ + continue; + } + result.add(ApplicationHomeSubCluster.newInstance(applicationId, subClusterId)); + appCount++; } - GetApplicationsHomeSubClusterResponse.newInstance(result); Review Comment: This line of code should be an extra line of code, which has no practical significance. The following is directly constructed and returned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org