slfan1989 commented on code in PR #4846: URL: https://github.com/apache/hadoop/pull/4846#discussion_r964250393
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/MemoryFederationStateStore.java: ########## @@ -255,17 +261,36 @@ public GetApplicationHomeSubClusterResponse getApplicationHomeSubCluster( @Override public GetApplicationsHomeSubClusterResponse getApplicationsHomeSubCluster( GetApplicationsHomeSubClusterRequest request) throws YarnException { - List<ApplicationHomeSubCluster> result = - new ArrayList<ApplicationHomeSubCluster>(); - for (Entry<ApplicationId, SubClusterId> e : applications.entrySet()) { - result - .add(ApplicationHomeSubCluster.newInstance(e.getKey(), e.getValue())); + + if (request == null) { + throw new YarnException("Missing getApplicationsHomeSubCluster request"); } - GetApplicationsHomeSubClusterResponse.newInstance(result); + SubClusterId requestSC = request.getSubClusterId(); + List<ApplicationHomeSubCluster> result = applications.keySet().stream() + .map(applicationId -> generateAppHomeSC(applicationId)) + .filter(appHomeSC -> judgeAdd(requestSC, appHomeSC.getHomeSubCluster())) + .limit(maxAppsInStateStore) + .collect(Collectors.toList()); + + LOG.info("filterSubClusterId = {}, appCount = {}.", requestSC, result.size()); return GetApplicationsHomeSubClusterResponse.newInstance(result); } + private ApplicationHomeSubCluster generateAppHomeSC(ApplicationId applicationId) { + SubClusterId subClusterId = applications.get(applicationId); + return ApplicationHomeSubCluster.newInstance(applicationId, subClusterId); + } + + private boolean judgeAdd(SubClusterId filterSubCluster, SubClusterId homeSubCluster) { + if (filterSubCluster == null) { + return true; + } else if (filterSubCluster.equals(homeSubCluster)) { Review Comment: Thanks for your help reviewing the code, I will modify the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org