steveloughran commented on code in PR #4862:
URL: https://github.com/apache/hadoop/pull/4862#discussion_r965178779
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/localfs/TestLocalFSContractVectoredRead.java:
##########
@@ -63,24 +87,55 @@ public void testChecksumValidationDuringVectoredRead()
throws Exception {
.describedAs("Checksum file should be present")
.isTrue();
CompletableFuture<FSDataInputStream> fis =
localFs.openFile(testPath).build();
- List<FileRange> someRandomRanges = new ArrayList<>();
- someRandomRanges.add(FileRange.createFileRange(10, 1024));
- someRandomRanges.add(FileRange.createFileRange(1025, 1024));
try (FSDataInputStream in = fis.get()){
- in.readVectored(someRandomRanges, getAllocate());
- validateVectoredReadResult(someRandomRanges, datasetCorrect);
+ in.readVectored(ranges, getAllocate());
+ validateVectoredReadResult(ranges, datasetCorrect);
}
- final byte[] datasetCorrupted = ContractTestUtils.dataset(DATASET_LEN,
'a', 64);
+ final byte[] datasetCorrupted = ContractTestUtils.dataset(length, 'a', 64);
try (FSDataOutputStream out = localFs.getRaw().create(testPath, true)){
out.write(datasetCorrupted);
}
CompletableFuture<FSDataInputStream> fisN =
localFs.openFile(testPath).build();
try (FSDataInputStream in = fisN.get()){
- in.readVectored(someRandomRanges, getAllocate());
+ in.readVectored(ranges, getAllocate());
// Expect checksum exception when data is updated directly through
// raw local fs instance.
intercept(ChecksumException.class,
- () -> validateVectoredReadResult(someRandomRanges,
datasetCorrupted));
+ () -> validateVectoredReadResult(ranges, datasetCorrupted));
+ }
+ }
+ @Test
+ public void tesChecksumVectoredReadBoundaries() throws Exception {
+ Path testPath = path("boundary_range_checksum_file");
+ final int length = 1071;
+ LocalFileSystem localFs = (LocalFileSystem) getFileSystem();
+ final byte[] datasetCorrect = ContractTestUtils.dataset(length, 'a', 32);
+ try (FSDataOutputStream out = localFs.create(testPath, true)){
+ out.write(datasetCorrect);
+ }
+ Path checksumPath = localFs.getChecksumFile(testPath);
+ Assertions.assertThat(localFs.exists(checksumPath))
+ .describedAs("Checksum file should be present")
Review Comment:
add path in message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
