slfan1989 commented on code in PR #4843: URL: https://github.com/apache/hadoop/pull/4843#discussion_r967845912
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestRouterWebServicesREST.java: ########## @@ -198,6 +202,7 @@ public Boolean get() { } }, 1000, 10 * 1000); } catch (Exception e) { + LOG.error("Web app not running", e); Review Comment: > Why do we do this? Isn't it clear enough with the "fail()" message? I understand your thoughts, you are right, the "fail()" message is enough, generally it is caused by timeout, I increased the timeout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org