[
https://issues.apache.org/jira/browse/HADOOP-18186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605976#comment-17605976
]
ASF GitHub Bot commented on HADOOP-18186:
-----------------------------------------
virajjasani commented on code in PR #4879:
URL: https://github.com/apache/hadoop/pull/4879#discussion_r973343199
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/ExecutorServiceFuturePool.java:
##########
@@ -64,6 +70,18 @@ public Future<Void> executeRunnable(final Runnable r) {
return (Future<Void>) executor.submit(r::run);
}
+ /**
+ * Utility to shutdown the {@link ExecutorService} used by this class. Will
wait up to a
+ * certain timeout for the ExecutorService to gracefully shutdown.
+ *
+ * @param logger Logger
+ * @param timeout the maximum time to wait
+ * @param unit the time unit of the timeout argument
+ */
+ public void shutdown(Logger logger, long timeout, TimeUnit unit) {
+ HadoopExecutors.shutdown(executor, logger, timeout, unit);
Review Comment:
Because the executor that we are shutting down is private to the
ExecutorServiceFuturePool.
> s3a prefetching to use SemaphoredDelegatingExecutor for submitting work
> -----------------------------------------------------------------------
>
> Key: HADOOP-18186
> URL: https://issues.apache.org/jira/browse/HADOOP-18186
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> Use SemaphoredDelegatingExecutor for each to stream to submit work, if
> possible, for better fairness in processes with many streams.
> this also takes a DurationTrackerFactory to count how long was spent in the
> queue, something we would want to know
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
