[ 
https://issues.apache.org/jira/browse/HADOOP-18457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17607127#comment-17607127
 ] 

ASF GitHub Bot commented on HADOOP-18457:
-----------------------------------------

cosmind-db commented on code in PR #4907:
URL: https://github.com/apache/hadoop/pull/4907#discussion_r975234278


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java:
##########
@@ -278,8 +282,8 @@ private boolean executeHttpOperation(final int retryCount,
       // dump the headers
       AbfsIoUtils.dumpHeadersToDebugLog("Request Headers",
           httpOperation.getConnection().getRequestProperties());
-      AbfsClientThrottlingIntercept.sendingRequest(operationType, 
abfsCounters);
-
+      intercept = 
AbfsClientThrottlingInterceptFactory.getInstance(accountName, 
isAutoThrottlingEnabled, isSingletonEnabled);

Review Comment:
   this naming is not consistent with the one used below. In one place the 
variable is called `intercept` and in another `instance`.  I guess the 
intention is for both cases to use the `intercept` variable ad L248? 





> ABFS: Support for account level throttling
> ------------------------------------------
>
>                 Key: HADOOP-18457
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18457
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 3.3.4
>            Reporter: Anmol Asrani
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>
> To add support for throttling at account level



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to