goiri commented on code in PR #4927: URL: https://github.com/apache/hadoop/pull/4927#discussion_r979129577
########## hadoop-yarn-project/hadoop-yarn/bin/FederationStateStore/SQLServer/FederationStateStoreDatabase.sql: ########## @@ -0,0 +1,26 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +-- Script to create a new Database in SQLServer for the Federation StateStore + +IF DB_ID ( '[FederationStateStore]') IS NOT NULL Review Comment: Are there some tests that now work? ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/Federation.md: ########## @@ -205,9 +205,25 @@ In the same directory we provide scripts to drop the Stored Procedures, the Tabl **Note:** the FederationStateStoreUser.sql defines a default user/password for the DB that you are **highly encouraged** to set this to a proper strong password. +The versions supported by MySQL are as follows: + +1. MySQL 5.7 +2. MySQL 8.0 +MySQL 5.7 and above can be used. + +**Note:** Cannot Support MySQL Versions Below MySQL 5.6 (includes MySQL 5.6) + For SQL-Server, the process is similar, but the jdbc driver is already included. SQL-Server scripts are located in **sbin/FederationStateStore/SQLServer/**. +The versions supported by SQL-Server are as follows: + +1. SQL Server 2008 R2 Enterprise +2. SQL Server 2012 Enterprise +3. SQL Server 2016 Enterprise +4. SQL Server 2017 Enterprise +5. SQL Server 2019 Enterprise +SQL Server 2008 R2 and above can be used. Review Comment: Isn't this implied by the given list? ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/Federation.md: ########## @@ -205,9 +205,25 @@ In the same directory we provide scripts to drop the Stored Procedures, the Tabl **Note:** the FederationStateStoreUser.sql defines a default user/password for the DB that you are **highly encouraged** to set this to a proper strong password. +The versions supported by MySQL are as follows: + +1. MySQL 5.7 +2. MySQL 8.0 +MySQL 5.7 and above can be used. Review Comment: This text and the note are a little redundant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
