slfan1989 commented on code in PR #4946:
URL: https://github.com/apache/hadoop/pull/4946#discussion_r988468178
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java:
##########
@@ -1099,4 +1099,61 @@ private RMWebServices prepareWebServiceForValidation(
return webService;
}
+ @Test
+ public void testClusterSchedulerOverviewFifo() throws JSONException,
Exception {
+ WebResource r = resource();
+ ClientResponse response = r.path("ws").path("v1").path("cluster")
+ .path("scheduler-overview").accept(MediaType.APPLICATION_JSON)
+ .get(ClientResponse.class);
+
+ assertEquals(MediaType.APPLICATION_JSON + "; " + JettyUtils.UTF_8,
+ response.getType().toString());
+ JSONObject json = response.getEntity(JSONObject.class);
+ verifyClusterSchedulerOverView(json, "Fifo Scheduler");
+ }
+
+ public static void verifyClusterSchedulerOverView(
+ JSONObject json, String expectedSchedulerType) throws Exception {
+
+ // why json contains 8 elements because we defined 8 fields
+ assertEquals("incorrect number of elements in: " + json, 8, json.length());
+
+ // 1.Verify that the schedulerType is as expected
+ String schedulerType = json.getString("schedulerType");
+ assertEquals(expectedSchedulerType, schedulerType);
+
+ // 2.Verify that schedulingResourceType is as expected
+ String schedulingResourceType = json.getString("schedulingResourceType");
+ assertEquals("memory-mb (unit=Mi),vcores", schedulingResourceType);
+
+ // 3.Verify that minimumAllocation is as expected
+ JSONObject minimumAllocation = json.getJSONObject("minimumAllocation");
+ String minMemory = minimumAllocation.getString("memory");
+ String minVCores = minimumAllocation.getString("vCores");
+ assertEquals("1024", minMemory);
+ assertEquals("1", minVCores);
+
+ // 4.Verify that maximumAllocation is as expected
+ JSONObject maximumAllocation = json.getJSONObject("maximumAllocation");
+ String maxMemory = maximumAllocation.getString("memory");
+ String maxVCores = maximumAllocation.getString("vCores");
+ assertEquals("8192", maxMemory);
+ assertEquals("4", maxVCores);
+
+ // 5.Verify that schedulerBusy is as expected
+ int schedulerBusy = json.getInt("schedulerBusy");
+ Assert.assertEquals(-1, schedulerBusy);
Review Comment:
Thanks a lot for your help reviewing the code, I'll fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
