K0K0V0K commented on code in PR #4655: URL: https://github.com/apache/hadoop/pull/4655#discussion_r993197109
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySchedulerConfiguration.java: ########## @@ -1200,7 +1207,24 @@ public ConfigurationProperties getConfigurationProperties() { public void reinitializeConfigurationProperties() { // Props are always Strings, therefore this cast is safe Map<String, String> props = (Map) getProps(); - configurationProperties = new ConfigurationProperties(props); + configurationProperties = new ConfigurationProperties(props, PREFIX); + } + + @Override + public void set(String name, String value) { + super.set(name, value); + if (configurationProperties != null) { + //The super#get method used cause the super#set contains some logic + configurationProperties.set(super.get(name), value); Review Comment: I think we should keep them in sync, cause if later someone wants to use the deprecation feature here, than a bug can be easily made -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org