[
https://issues.apache.org/jira/browse/HADOOP-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616728#comment-17616728
]
ASF GitHub Bot commented on HADOOP-8728:
----------------------------------------
goiri commented on code in PR #5010:
URL: https://github.com/apache/hadoop/pull/5010#discussion_r993981139
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Display.java:
##########
@@ -217,8 +216,8 @@ protected void processPath(PathData item) throws
IOException {
protected class TextRecordInputStream extends InputStream {
SequenceFile.Reader r;
- Writable key;
- Writable val;
+ Object key;
Review Comment:
What is the use case to not base it on Writable? The whole principal is to
use Writable.
> Display (fs -text) shouldn't hard-depend on Writable serialized sequence
> files.
> -------------------------------------------------------------------------------
>
> Key: HADOOP-8728
> URL: https://issues.apache.org/jira/browse/HADOOP-8728
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.6.0
> Reporter: Harsh J
> Assignee: Ashutosh Gupta
> Priority: Minor
> Labels: BB2015-05-TBR, pull-request-available
> Attachments: HADOOP-8728-002.patch, HADOOP-8728-003.patch,
> HADOOP-8728.patch
>
>
> The Display command (fs -text) currently reads only Writable-based
> SequenceFiles. This isn't necessary to do, and prevents reading
> non-Writable-based serialization in SequenceFiles from the shell.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
